Re: [meta-oe][PATCH] grpc: Update to 1.50.x release


Martin Jansa
 

I can confirm that grpc upgrade fixed compatibility with abseil-cpp upgrade from:

FWIW: We had around 5 more failing recipes in internal layers caused by this abseil-cpp upgrade, explicitly setting std to c++14 worked for all of them, e.g. in pulseaudio:

Cheers,

On Sun, Oct 30, 2022 at 3:07 AM Randy MacLeod <randy.macleod@...> wrote:
On 2022-10-29 19:56, Khem Raj wrote:
> On Sat, Oct 29, 2022 at 2:08 PM Randy MacLeod
> <randy.macleod@...> wrote:
>>
>> On 2022-10-18 13:31, Khem Raj wrote:
>>
>> License-update: Include MPL-2.0 [1]
>>
>> Add missing BSD 3-clause and MPL-2.0 to license field
>>
>> Switch to git submodules since its using locked versions of some
>> components like opencensus-proto
>>
>> [1] https://github.com/grpc/grpc/commit/05fcd826f477ef1a024a2defa5e4b3d78f5e6eb4
>> Signed-off-by: Khem Raj <raj.khem@...>
>> ---
>>   .../grpc/{grpc_1.45.2.bb => grpc_1.50.0.bb}            | 10 +++++-----
>>
>>
>> Is anyone else seeing:
>>
>> error: #error "C++ versions less than C++14 are not supported."
>>
>>
>> i.e.
>>
>> TOPDIR/tmp-glibc/hosttools/g++ -Dgpr_EXPORTS \
>> -ITOPDIR/tmp-glibc/work/x86_64-linux/grpc-native/1.45.2-r0/git/include \
>> -ITOPDIR/tmp-glibc/work/x86_64-linux/grpc-native/1.45.2-r0/git \
>> -ITOPDIR/tmp-glibc/work/x86_64-linux/grpc-native/1.45.2-r0/git/third_party/address_sorting/include \
>> -ITOPDIR/tmp-glibc/work/x86_64-linux/grpc-native/1.45.2-r0/git/src/core/ext/upb-generated \
>> -ITOPDIR/tmp-glibc/work/x86_64-linux/grpc-native/1.45.2-r0/git/src/core/ext/upbdefs-generated \
>> -ITOPDIR/tmp-glibc/work/x86_64-linux/grpc-native/1.45.2-r0/git/third_party/upb \
>> -ITOPDIR/tmp-glibc/work/x86_64-linux/grpc-native/1.45.2-r0/git/third_party/xxhash \
>> -isystemTOPDIR/tmp-glibc/work/x86_64-linux/grpc-native/1.45.2-r0/recipe-sysroot-native/usr/include \
>> -O2 -pipe -Wl,--no-as-needed -fPIC -std=c++11 \
>> -MD -MT \
>> CMakeFiles/gpr.dir/src/core/lib/gpr/murmur_hash.cc.o \
>> -MF \
>> CMakeFiles/gpr.dir/src/core/lib/gpr/murmur_hash.cc.o.d \
>> -o \
>> CMakeFiles/gpr.dir/src/core/lib/gpr/murmur_hash.cc.o \
>> -c \
>> TOPDIR/tmp-glibc/work/x86_64-linux/grpc-native/1.45.2-r0/git/src/core/lib/gpr/murmur_hash.cc
>> In file included from
>> TOPDIR/tmp-glibc/work/x86_64-linux/grpc-native/1.45.2-r0/recipe-sysroot-native/usr/include/absl/base/config.h:86,
>> from
>> TOPDIR/tmp-glibc/work/x86_64-linux/grpc-native/1.45.2-r0/recipe-sysroot-native/usr/include/absl/base/attributes.h:37, \
>> from \
>> TOPDIR/tmp-glibc/work/x86_64-linux/grpc-native/1.45.2-r0/git/src/core/lib/gpr/murmur_hash.cc:25: \
>> TOPDIR/tmp-glibc/work/x86_64-linux/grpc-native/1.45.2-r0/recipe-sysroot-native/usr/include/absl/base/policy_checks.h:79:2: \
>> error: #error "C++ versions less than C++14 are not supported."
>> 79 | #error "C++ versions less than C++14 are not supported." \
>> | ^~~~~
>>
>>
>> Happening for a variety of distros.
>>
>> fedora: 34, 35, 36, ubuntu: 1804, 2004, opensuse153
>
> you seem to be still building 1.45.2 and the upgrade to 1.50x fixed
> exactly this.

Huh, look at that.

Thanks Khem.
../Randy

>
>>
>>
>> ../Randy
>>
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>   rename meta-oe/recipes-devtools/grpc/{grpc_1.45.2.bb => grpc_1.50.0.bb} (90%)
>>
>> diff --git a/meta-oe/recipes-devtools/grpc/grpc_1.45.2.bb b/meta-oe/recipes-devtools/grpc/grpc_1.50.0.bb
>> similarity index 90%
>> rename from meta-oe/recipes-devtools/grpc/grpc_1.45.2.bb
>> rename to meta-oe/recipes-devtools/grpc/grpc_1.50.0.bb
>> index c2f952fc64..8efd9321ca 100644
>> --- a/meta-oe/recipes-devtools/grpc/grpc_1.45.2.bb
>> +++ b/meta-oe/recipes-devtools/grpc/grpc_1.50.0.bb
>> @@ -3,8 +3,8 @@ Provides gRPC libraries for multiple languages written on top of shared C core l
>>   (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)"
>>   HOMEPAGE = "https://github.com/grpc/grpc"
>>   SECTION = "libs"
>> -LICENSE = "Apache-2.0"
>> -LIC_FILES_CHKSUM = "file://LICENSE;md5=6e4cf218112648d22420a84281b68b88"
>> +LICENSE = "Apache-2.0 && BSD-3-Clause && MPL-2.0"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=731e401b36f8077ae0c134b59be5c906"
>>
>>   DEPENDS = "c-ares protobuf protobuf-native protobuf-c protobuf-c-native openssl libnsl2 abseil-cpp re2"
>>   DEPENDS:append:class-target = " googletest grpc-native "
>> @@ -20,9 +20,9 @@ RDEPENDS:${PN}-dev:append:class-native = " ${PN}-compiler"
>>   # RDEPENDS:${PN}-dev += "${PN}-compiler"
>>
>>   S = "${WORKDIR}/git"
>> -SRCREV_grpc = "b39ffcc425ea990a537f98ec6fe6a1dcb90470d7"
>> -BRANCH = "v1.45.x"
>> -SRC_URI = "git://github.com/grpc/grpc.git;protocol=https;name=grpc;branch=${BRANCH} \
>> +SRCREV_grpc = "91091e3668144de9c6aa392f496bb7639f7025a7"
>> +BRANCH = "v1.50.x"
>> +SRC_URI = "gitsm://github.com/grpc/grpc.git;protocol=https;name=grpc;branch=${BRANCH} \
>>              file://0001-Revert-Changed-GRPCPP_ABSEIL_SYNC-to-GPR_ABSEIL_SYNC.patch \
>>              file://0001-cmake-add-separate-export-for-plugin-targets.patch \
>>              file://0001-cmake-Link-with-libatomic-on-rv32-rv64.patch \
>>
>>
>>
>>
>>
>> --
>> # Randy MacLeod
>> # Wind River Linux

--
# Randy MacLeod
# Wind River Linux




Join openembedded-devel@lists.openembedded.org to automatically receive all group messages.