Re: [meta-networking][kirkstone][PATCH] networkmanager: fix build with enabled ppp


Khem Raj
 



On Fri, Jul 1, 2022 at 7:45 AM Otavio Salvador <otavio.salvador@...> wrote:


Em seg., 27 de jun. de 2022 às 10:39, Javier Viguera via lists.openembedded.org <javier.viguera=digi.com@...> escreveu:
If 'ppp' packageconfig option is enabled, but the build system does NOT
have pppd binary installed, the build fails with:

| Has header "pppd/pppd.h" : YES
| Program pppd /sbin/pppd /usr/sbin/pppd found: NO
|
| ../NetworkManager-1.36.2/meson.build:570:4: ERROR: Assert failed: pppd required but not found, please provide a valid pppd path or use -Dppp=false to disable it

This is due to meson trying to look for the 'pppd' binary in the build
system when it should not. If the build system does not contain pppd,
the build fails.

Signed-off-by: Javier Viguera <javier.viguera@...>

Please send it against master, first, then we can ask for backports.

I have staged it with a bit of editing 

 
--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750



Join openembedded-devel@lists.openembedded.org to automatically receive all group messages.