Re: [PATCH] libpwquality: Add option to disable python bindings

Jose Quaresma

Hi Noah,

Noah Brewer <noah.t.brewer@...> escreveu no dia terça, 28/06/2022 à(s) 21:48:
From: Noah Brewer <noah.t.brewer@...>

Remove python3-core from RDEPENDS when the appropriate PACKAGECONFIG
is set using the remove operator. Use bbappend file to set PACKAGECONFIG
to disable python bindings and to remove python3-core from RDEPENDS.

Signed-off-by: Noah Brewer <noah.t.brewer@...>
 meta-oe/recipes-extended/libpwquality/ | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-extended/libpwquality/ b/meta-oe/recipes-extended/libpwquality/
index f892cc650..ea3787792 100644
--- a/meta-oe/recipes-extended/libpwquality/
+++ b/meta-oe/recipes-extended/libpwquality/
@@ -32,9 +32,11 @@ EXTRA_OECONF += "--with-python-rev=${PYTHON_BASEVERSION} \
                  --libdir=${libdir} \

-PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)}"
+PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)} python-bindings"
+PACKAGECONFIG[python-bindings] = "--enable-python-bindings=yes, --enable-python-bindings=no"
 PACKAGECONFIG[pam] = "--enable-pam, --disable-pam, libpam"

+RDEPENDS:${PN}:remove = "${@bb.utils.contains('PACKAGECONFIG', 'python-bindings', '', '${PYTHON_PN}-core', d)}"

We can't override the remove operator so if you use remove no one can undo that.
Please use inverted logic with RDEPENDS:${PN}:append so it is possible to use remove if needed in bbappend.

Anyway we can add RDEPENDS with the PACKAGECONFIG (it is the argument number 4)

+PACKAGECONFIG[python-bindings] = "--enable-python-bindings=yes, --enable-python-bindings=no,,python3-core"


 FILES:${PN} += "${libdir}/security/"
 FILES:${PN}-dbg += "${libdir}/security/.debug"
 FILES:${PN}-staticdev += "${libdir}/security/pam_pwquality.a"

Best regards,

José Quaresma

Join to automatically receive all group messages.