Re: [honister][PATCH] insane.bbclass: Correct package_qa_check_empty_dirs()

Peter Kjellerstedt

Actually, it shouldn’t have been sent at all as I had already sent it to the oe-core list.




From: Martin Jansa <martin.jansa@...>
Sent: den 8 februari 2022 16:50
To: Peter Kjellerstedt <peter.kjellerstedt@...>
Cc: openembedded-devel@...
Subject: Re: [oe] [honister][PATCH] insane.bbclass: Correct package_qa_check_empty_dirs()


This should be sent to oe-core ML.


On Tue, Feb 8, 2022 at 4:47 PM Peter Kjellerstedt <peter.kjellerstedt@...> wrote:

The method is not available in Honister, use
package_qa_add_message() instead.

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@...>
 meta/classes/insane.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index bfaf2577d0..2c8f5338e5 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -945,7 +945,7 @@ def package_qa_check_empty_dirs(pkg, d, messages):
             recommendation = (d.getVar('QA_EMPTY_DIRS_RECOMMENDATION:' + dir) or
                               "but it is expected to be empty")
             msg = "%s installs files in %s, %s" % (pkg, dir, recommendation)
-  , "empty-dirs", msg)
+            package_qa_add_message(messages, "empty-dirs", msg)

 def package_qa_check_encoding(keys, encode, d):
     def check_encoding(key, enc):

Join { to automatically receive all group messages.