Re: [meta-networking][PATCH 1/2] bluepy: Set PV and correct syntax for RDEPENDS


Martin Jansa
 

Thanks! <3

On Wed, Oct 20, 2021 at 7:22 PM Khem Raj <raj.khem@...> wrote:
Also organize the recipe to to match OE style
Remove PYTHON_PN from DEPENDS, setuptools should be enough
Correct setting LIC_FILES_CHKSUM
Move setting git SHA to SRCREV

Signed-off-by: Khem Raj <raj.khem@...>
Cc: Marco Cavallini <m.cavallini@...>
Cc: Martin Jansa <martin.jansa@...>
---
 .../recipes-connectivity/bluepy/bluepy_git.bb    | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/meta-networking/recipes-connectivity/bluepy/bluepy_git.bb b/meta-networking/recipes-connectivity/bluepy/bluepy_git.bb
index 03b1562b60..c1bcbc25b1 100644
--- a/meta-networking/recipes-connectivity/bluepy/bluepy_git.bb
+++ b/meta-networking/recipes-connectivity/bluepy/bluepy_git.bb
@@ -1,17 +1,19 @@
 DESCRIPTION = "Python interface to Bluetooth LE on Linux"
 HOMEPAGE = "https://github.com/IanHarvey/bluepy"
 SECTION = "devel/python"
+LICENSE = "GPLv2 & PD"
+LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6 \
+                    file://${COREBASE}/meta/files/common-licenses/PD;md5=b3597d12946881e13cb3b548d1173851"
+DEPENDS = "glib-2.0"
+SRCREV = "7ad565231a97c304c0eff45f2649cd005e69db09"
+PV = "1.3.0+git${SRCPV}"

-DEPENDS = "${PYTHON_PN} glib-2.0"
-RDEPENDS_${PN} = "bluez5"
+SRC_URI = "git://github.com/IanHarvey/bluepy.git;protocol=https"

-LICENSE = "GPLv2 & PD"
-LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6"
-LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/PD;md5=b3597d12946881e13cb3b548d1173851"
+S = "${WORKDIR}/git"

 inherit setuptools3 pkgconfig

-SRC_URI = "git://github.com/IanHarvey/bluepy.git;protocol=https;rev=7ad565231a97c304c0eff45f2649cd005e69db09"
-S = "${WORKDIR}/git"
+RDEPENDS:${PN} = "bluez5"

 TARGET_CC_ARCH += "${LDFLAGS}"
--
2.33.1

Join openembedded-devel@lists.openembedded.org to automatically receive all group messages.