Re: [meta-oe][PATCH v2 2/2] sdbus-cpp: Do not fetch googletest on the fly


Martin Jansa
 

On Thu, May 27, 2021 at 05:39:36PM -0700, Khem Raj wrote:
This package downloads code ( gtest ) post do_fetch task

Now this is checked out by bitbake fetcher into decided source directory,
this ensures reproducibility

Signed-off-by: Khem Raj <raj.khem@...>
---
v2: Fetch googletest via bitbake

...-Do-not-download-gtest-automatically.patch | 44 +++++++++++++++++++
.../recipes-core/sdbus-c++/sdbus-c++_0.8.3.bb | 10 ++++-
2 files changed, 52 insertions(+), 2 deletions(-)
create mode 100644 meta-oe/recipes-core/sdbus-c++/sdbus-c++-0.8.3/0001-Do-not-download-gtest-automatically.patch

diff --git a/meta-oe/recipes-core/sdbus-c++/sdbus-c++_0.8.3.bb b/meta-oe/recipes-core/sdbus-c++/sdbus-c++_0.8.3.bb
index 98829765c2..91cf70c911 100644
--- a/meta-oe/recipes-core/sdbus-c++/sdbus-c++_0.8.3.bb
+++ b/meta-oe/recipes-core/sdbus-c++/sdbus-c++_0.8.3.bb
@@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=1803fa9c2c3ce8cb06b4861d75310742"
inherit cmake pkgconfig systemd ptest

PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'with-external-libsystemd', 'with-builtin-libsystemd', d)} \
- ${@bb.utils.contains('PTEST_ENABLED', '1', 'with-tests', '', d)}"
+ ${@bb.utils.contains('PTEST_ENABLED', '0', 'with-tests', '', d)}"
^ is this change intentional?

PACKAGECONFIG[with-builtin-libsystemd] = ",,sdbus-c++-libsystemd,libcap"
PACKAGECONFIG[with-external-libsystemd] = ",,systemd,libsystemd"
PACKAGECONFIG[with-tests] = "-DBUILD_TESTS=ON -DTESTS_INSTALL_PATH=${libdir}/${BPN}/tests,-DBUILD_TESTS=OFF"

Join openembedded-devel@lists.openembedded.org to automatically receive all group messages.