[PATCH 2/3] libc-locale: Fix on target locale generation


Richard Purdie
 

If on target locale generation is used, it fails at first boot showing
errors about a missing directory. Ensure the directory exists.

Signed-off-by: Richard Purdie <richard.purdie@...>
---
meta/classes-recipe/libc-package.bbclass | 1 +
1 file changed, 1 insertion(+)

diff --git a/meta/classes-recipe/libc-package.bbclass b/meta/classes-recipe/libc-package.bbclass
index de3d4223a8c..8a99f73ae72 100644
--- a/meta/classes-recipe/libc-package.bbclass
+++ b/meta/classes-recipe/libc-package.bbclass
@@ -51,6 +51,7 @@ PACKAGE_NO_GCONV ?= "0"
OVERRIDES:append = ":${TARGET_ARCH}-${TARGET_OS}"

locale_base_postinst_ontarget() {
+mkdir ${libdir}/locale
localedef --inputfile=${datadir}/i18n/locales/%s --charmap=%s %s
}

--
2.37.2


Khem Raj
 

On Sat, Feb 4, 2023 at 3:41 AM Richard Purdie
<richard.purdie@...> wrote:

If on target locale generation is used, it fails at first boot showing
errors about a missing directory. Ensure the directory exists.

Signed-off-by: Richard Purdie <richard.purdie@...>
---
meta/classes-recipe/libc-package.bbclass | 1 +
1 file changed, 1 insertion(+)

diff --git a/meta/classes-recipe/libc-package.bbclass b/meta/classes-recipe/libc-package.bbclass
index de3d4223a8c..8a99f73ae72 100644
--- a/meta/classes-recipe/libc-package.bbclass
+++ b/meta/classes-recipe/libc-package.bbclass
@@ -51,6 +51,7 @@ PACKAGE_NO_GCONV ?= "0"
OVERRIDES:append = ":${TARGET_ARCH}-${TARGET_OS}"

locale_base_postinst_ontarget() {
+mkdir ${libdir}/locale
should it be mkdir -p for when it does exist beforehand ?

localedef --inputfile=${datadir}/i18n/locales/%s --charmap=%s %s
}

--
2.37.2




Richard Purdie
 

On Sat, 2023-02-04 at 17:07 -0800, Khem Raj wrote:
On Sat, Feb 4, 2023 at 3:41 AM Richard Purdie
<richard.purdie@...> wrote:

If on target locale generation is used, it fails at first boot showing
errors about a missing directory. Ensure the directory exists.

Signed-off-by: Richard Purdie <richard.purdie@...>
---
meta/classes-recipe/libc-package.bbclass | 1 +
1 file changed, 1 insertion(+)

diff --git a/meta/classes-recipe/libc-package.bbclass b/meta/classes-recipe/libc-package.bbclass
index de3d4223a8c..8a99f73ae72 100644
--- a/meta/classes-recipe/libc-package.bbclass
+++ b/meta/classes-recipe/libc-package.bbclass
@@ -51,6 +51,7 @@ PACKAGE_NO_GCONV ?= "0"
OVERRIDES:append = ":${TARGET_ARCH}-${TARGET_OS}"

locale_base_postinst_ontarget() {
+mkdir ${libdir}/locale
should it be mkdir -p for when it does exist beforehand ?
I wondered about that, then I wondered about portability with a minimal
busybox and decided libdir likely will exist...

Cheers,

Richard