On Tue, Jan 13, 2015 at 12:35 AM, Anders Darander <anders@...> wrote:

* Andre McCurdy <armccurdy@...> [150113 01:57]:

+# TODO: logrotate 3.8.8 adds autotools/automake support, update recipe to use it.
+# TODO: Document coreutils dependency. Why not RDEPENDS? Why not busybox?

It might well be worth adding autotools support right now.

DEPENDS="coreutils popt"

LIC_FILES_CHKSUM = "file://COPYING;md5=18810669f13b87348459e611d31ab760"
@@ -21,6 +24,9 @@ PACKAGECONFIG ?= "\
${@base_contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)} \
"

+PACKAGECONFIG[acl] = ",,acl"
+PACKAGECONFIG[selinux] = ",,libselinux"

The problem with these two lines, are that you're not explicitly
enabling and disabling those two features; thus our builds won't be
deterministic.

Currently the configure task for logrotate is a no-op, so the normal
way of constructing a configure command line via PACKAGECONFIG doesn't
work.

We do however need to include acl and libselinux in DEPENDS if enabled
- which wasn't happening before and is what the patch attempts to fix,

There are no floating dependencies since acl and selinux are enabled
explicitly during compile, by options passed on the make command line
via EXTRA_OEMAKE.

Depending on how the actual tests are performed in the logrotate
sources, it might happen that you're enabling the features just by
making sure that they're going to be built prior to logrotate. Though,
there's no guarantee that this will work (without looking at the source
code).

However, if that enabling works, then we have the problem that the
features will always be activated regardless of whether we add acl and
selinux to PACKAGECONFIG, if these exists in the sysroot. Thus, the
build is undeterministic.

Could you please look at enabling / disabling those features explicitly?

Cheers,
Anders
--
Anders Darander
ChargeStorm AB / eStorm AB