Re: PR to fix WantedBy parsing of systemctl


Martin Jansa
 

see the REMOTE_URL changes shown in set -x, relevant context is in: https://git.openembedded.org/openembedded-core/commit/?id=675e88e6e0bbd5ab2dcd4bdf97b0de59925a1be6

We forgot to update it after:
and unfortunately it shows how rarely this script is being used.

I've sent a fix for this, please test it.

On Mon, Sep 26, 2022 at 9:50 PM Robert Henz via lists.openembedded.org <robert_henz=jabil.com@...> wrote:
I think I'm missing some context. Not really understanding what this script is trying to accomplish I don't know what "remote branch" is vs "local branch". Should "remote branch" be "master" and the local branch be the branch with the change I want to make? Here's that script running with "set -x" turned on 1/2 way through...

bobhenz@hound:~/src/openembedded-core$ scripts/create-pull-request -u badger
+ USER_RE=[A-Za-z0-9_.@][A-Za-z0-9_.@-]*$\?
+ PROTO_RE=[a-z][a-z+]*://
+ GIT_RE=\(^\([a-z][a-z+]*://\)\?\)\([A-Za-z0-9_.@][A-Za-z0-9_.@-]*$\?@\)\?\([^:/]*\)[:/]\(.*\)
+ REMOTE_URL=https://github.com/BadgerTechnologies/openembedded-core
+ echo https://github.com/BadgerTechnologies/openembedded-core
+ sed s#\(^\([a-z][a-z+]*://\)\?\)\([A-Za-z0-9_.@][A-Za-z0-9_.@-]*$\?@\)\?\([^:/]*\)[:/]\(.*\)#\5#
+ REMOTE_REPO=BadgerTechnologies/openembedded-core
+ echo https://github.com/BadgerTechnologies/openembedded-core
+ sed s#\(^\([a-z][a-z+]*://\)\?\)\([A-Za-z0-9_.@][A-Za-z0-9_.@-]*$\?@\)\?\([^:/]*\)[:/]\(.*\)#git://\4/\5#
+ REMOTE_URL=git://github.com/BadgerTechnologies/openembedded-core
+ [ -z  ]
+ git branch
+ grep -e ^\*
+ cut -d  -f2
+ BRANCH=fix-wantedby-clearing
+ echo NOTE: Assuming remote branch 'fix-wantedby-clearing', use -b to override.
NOTE: Assuming remote branch 'fix-wantedby-clearing', use -b to override.
+ [ -z  ]
+ L_BRANCH=HEAD
+ echo NOTE: Assuming local branch HEAD, use -l to override.
NOTE: Assuming local branch HEAD, use -l to override.
+ [ 0 -eq 1 ]
+ WEB_URL=
+ WEB_URL=https://github.com/BadgerTechnologies/openembedded-core/tree/fix-wantedby-clearing
+ [ -n https://github.com/BadgerTechnologies/openembedded-core/tree/fix-wantedby-clearing ]
+ [  = 1 ]
+ wget --no-check-certificate -q https://github.com/BadgerTechnologies/openembedded-core/tree/fix-wantedby-clearing -O /dev/null
+ [ 0 -ne 0 ]
+ [ -e pull-186156 ]
+ mkdir pull-186156
+ [ -n  ]
+ git format-patch -M40 --subject-prefix=PATCH -n -o pull-186156 --thread=shallow --cover-letter master..HEAD
+ ls -A pull-186156
+ [ -z 0000-cover-letter.patch
0001-Fix-WantedBy-processing.patch ]
+ [ -n  ]
+ echo pull-186156/0000-cover-letter.patch
+ CL=pull-186156/0000-cover-letter.patch
+ PM=pull-186156/pull-msg
+ + trgit -d --version
 [:alpha:][:space:].
+ sed s/\(...\).*/\1/
+ git version 2.25.1
+ GIT_VERSION=225
+ NEWER_GIT_VERSION=210
+ [ 225 -lt 210 ]
+ git request-pull master git://github.com/BadgerTechnologies/openembedded-core HEAD:fix-wantedby-clearing
fatal: unable to connect to github.com:
github.com[0: 140.82.113.3]: errno=Connection timed out

warn: No match for commit b637a46f58b5adc7dcc76bdef90a7be8c8462df8 found at git://github.com/BadgerTechnologies/openembedded-core
warn: Are you sure you pushed 'fix-wantedby-clearing' there?
+ [ 1 -ne 0 ]
+ echo ERROR: git request-pull reported an error
ERROR: git request-pull reported an error
+ rm -rf pull-186156
+ exit 1


Join openembedded-core@lists.openembedded.org to automatically receive all group messages.