Re: [PATCH 1/5] zip: Enable largefile support based on distro feature

Andre McCurdy

On Wed, Aug 10, 2022 at 10:54 PM Khem Raj <raj.khem@...> wrote:

The configure test tries to run a binary during build to determine
largefile support, which wont work in cross-compile mode, therefore
specify it when largefile DISTRO_FEATURE is on.

Signed-off-by: Khem Raj <raj.khem@...>
meta/recipes-extended/zip/ | 2 ++
1 file changed, 2 insertions(+)

diff --git a/meta/recipes-extended/zip/ b/meta/recipes-extended/zip/
index 07a67b96348..d560c83464b 100644
--- a/meta/recipes-extended/zip/
+++ b/meta/recipes-extended/zip/
@@ -29,6 +29,8 @@ CVE_CHECK_IGNORE += "CVE-2018-13410"
# Not for zip but for smart contract implementation for it
CVE_CHECK_IGNORE += "CVE-2018-13684"

+CFLAGS += "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', '-DLARGE_FILE_SUPPORT', '', d)}"
This should be hardcoded to enable LFS. The largefile distro feature
isn't used in oe-core (ie disabling LFS is not supported or even
possible anymore). The distro feature should be removed completely at
some point... when recipes in meta-oe etc have stopped referring to
it. See release notes from OE 2.3 (ie May 2017):

# sets CFLAGS, but what Makefile actually uses is
# CFLAGS_NOOPT. It will also force -O3 optimization, overriding
# whatever we set.

Join to automatically receive all group messages.