Re: [RFC PATCH 1/3] recipetool: Separate licenses with & operator


Alexander Kanavin
 

I mean that by reading the patch and the commit message it is not clear what problem is being fixed. It needs to be explained by showing what happens when there is no patch, and what happens when there is.

Alex


On Mon, 13 Dec 2021 at 14:01, Stefan Herbrechtsmeier <stefan.herbrechtsmeier-oss@...> wrote:
Am 13.12.2021 um 14:00 schrieb Stefan Herbrechtsmeier via
lists.openembedded.org:
>
>
> Am 13.12.2021 um 13:57 schrieb Alexander Kanavin:
>> On Mon, 13 Dec 2021 at 13:38, Stefan Herbrechtsmeier
>> <stefan.herbrechtsmeier-oss@...
>> <mailto:stefan.herbrechtsmeier-oss@...>> wrote:
>>
>>     From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@...
>>     <mailto:stefan.herbrechtsmeier@...>>
>>
>>     Separate licenses with & operator since it should be satisfied
>> most use
>>     cases and it is a reasonable assumption that all the licenses apply.
>>     Furthermore flat, split and sort the licenses to minimize license
>> string
>>     changes.
>>
>>
>> I think this is better explained with an example. What did not work
>> before, and what works with this change?
>
> Do you mean something like:
>
> -LICENSE = "MIT ISC Unknown"
> +LICENSE = "BSD-3-Clause & ISC & MIT & Unknown"

Sorry I mean:

-LICENSE = "MIT ISC Unknown"
+LICENSE = "ISC & MIT & Unknown"

Join {openembedded-core@lists.openembedded.org to automatically receive all group messages.