Re: [PATCH v2 2/2] vim: set PACKAGECONFIG idiomatically


Andre McCurdy
 

On Tue, Nov 30, 2021 at 8:53 AM Ross Burton <ross@...> wrote:

Don't set an empty default value and them immediately assign to it.

Signed-off-by: Ross Burton <ross.burton@...>
---
meta/recipes-support/vim/vim.inc | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/meta/recipes-support/vim/vim.inc b/meta/recipes-support/vim/vim.inc
index 6cdf157cb6..a0692755b6 100644
--- a/meta/recipes-support/vim/vim.inc
+++ b/meta/recipes-support/vim/vim.inc
@@ -67,9 +67,7 @@ do_compile() {
autotools_do_compile
}

-#Available PACKAGECONFIG options are gtkgui, acl, x11, tiny selinux, elfutils, nls
-PACKAGECONFIG ??= ""
-PACKAGECONFIG += " \
+PACKAGECONFIG ??= "\
This isn't equivalent - it will cause a change in behaviour for anyone
using PACKAGECONFIG += "foo" from a .bbappend.

${@bb.utils.filter('DISTRO_FEATURES', 'acl selinux', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 gtkgui', '', d)} \
nls \
--
2.25.1



Join openembedded-core@lists.openembedded.org to automatically receive all group messages.