Re: [PATCH] recipe-graphics: Add depends on cmake-native


Andre McCurdy
 

On Wed, Nov 10, 2021 at 5:41 PM Peter Kjellerstedt
<peter.kjellerstedt@...> wrote:

-----Original Message-----
From: openembedded-core@... <openembedded-core@...> On Behalf Of Anibal Limon
Sent: den 11 november 2021 01:44
To: openembedded-core@...
Cc: richard.purdie@...; Aníbal Limón <anibal.limon@...>
Subject: [OE-core] [PATCH] recipe-graphics: Add depends on cmake-native
Change "recipe-graphics" to "waffle".

//Peter


Fixes,

...
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/site-packages/mesonbuild/modules/cmake.py", line 241, in detect_cmake
p, stdout, stderr = mesonlib.Popen_safe(cmakebin.get_command() + ['--system-information', '-G', 'Ninja'])[0:3]
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/site-packages/mesonbuild/mesonlib/universal.py", line 1397, in Popen_safe
p = subprocess.Popen(args, universal_newlines=True, close_fds=False,
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/subprocess.py", line 966, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/subprocess.py", line 1717, in _execute_child
and os.path.dirname(executable)
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/posixpath.py", line 152, in dirname
p = os.fspath(p)
...

Signed-off-by: Aníbal Limón <anibal.limon@...>
---
meta/recipes-graphics/waffle/waffle_1.7.0.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/waffle/waffle_1.7.0.bb b/meta/recipes-graphics/waffle/waffle_1.7.0.bb
index 6284af3076..ea11309940 100644
--- a/meta/recipes-graphics/waffle/waffle_1.7.0.bb
+++ b/meta/recipes-graphics/waffle/waffle_1.7.0.bb
@@ -17,7 +17,7 @@ S = "${WORKDIR}/git"

inherit meson features_check lib_package bash-completion pkgconfig

-DEPENDS:append = " python3"
+DEPENDS:append = " python3 cmake-native"
It's unusual for a recipe to add cmake-native to DEPENDS rather than
inheriting the cmake class. Your patch comments should probably
explain why it's the correct approach.

# This should be overridden per-machine to reflect the capabilities of the GL
# stack.
--
2.33.1


Join openembedded-core@lists.openembedded.org to automatically receive all group messages.