Re: [PATCH 3/5] gcc-common.inc: Clean up the additions to MIRRORS


Andre McCurdy
 

On Wed, Nov 10, 2021 at 3:19 PM Peter Kjellerstedt
<peter.kjellerstedt@...> wrote:

Since commit 044fb04d in bitbake (fetch2: Allow whitespace only mirror
entries) there is no need to separate the entries in MIRRORS with "\n".

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@...>
---
meta/recipes-devtools/gcc/gcc-common.inc | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/meta/recipes-devtools/gcc/gcc-common.inc b/meta/recipes-devtools/gcc/gcc-common.inc
index 74190644e6..0d950e780d 100644
--- a/meta/recipes-devtools/gcc/gcc-common.inc
+++ b/meta/recipes-devtools/gcc/gcc-common.inc
@@ -86,11 +86,11 @@ get_tune_parameters[vardepsexclude] = "AVAILTUNES TUNE_CCARGS OVERRIDES TUNE_FEA
DEBIANNAME:${MLPREFIX}libgcc = "libgcc1"

MIRRORS =+ "\
-${GNU_MIRROR}/gcc ftp://gcc.gnu.org/pub/gcc/releases/ \n \
-${GNU_MIRROR}/gcc ftp://gd.tuwien.ac.at/gnu/gcc/ \n \
-${GNU_MIRROR}/gcc http://mirrors.rcn.net/pub/sourceware/gcc/releases/ \n \
-${GNU_MIRROR}/gcc http://gcc.get-software.com/releases/ \n \
-${GNU_MIRROR}/gcc http://gcc.get-software.com/releases/ \n \
+ ${GNU_MIRROR}/gcc ftp://gcc.gnu.org/pub/gcc/releases/ \
+ ${GNU_MIRROR}/gcc ftp://gd.tuwien.ac.at/gnu/gcc/ \
+ ${GNU_MIRROR}/gcc http://mirrors.rcn.net/pub/sourceware/gcc/releases/ \
+ ${GNU_MIRROR}/gcc http://gcc.get-software.com/releases/ \
+ ${GNU_MIRROR}/gcc http://gcc.get-software.com/releases/ \
Last two lines are duplicates. ftp mirrors should probably be replaced
with https.

Are these even useful at all? They were added in 2012...

"
#
# Set some default values


Join openembedded-core@lists.openembedded.org to automatically receive all group messages.