Re: [PATCH] vim: add option to disable NLS support

Andre McCurdy

On Mon, Aug 23, 2021 at 10:12 AM Andrej Valek <andrej.valek@...> wrote:

Hello Khem,

I looked exactly into which arguments are expecting for those options. So I think, it has to be mentioned explicitly.
Assuming is based around AC_ARG_ENABLE / AC_ARG_WITH then
an explicit option is not required. A default value of "yes" will be
set for --enable-foo / --with-foo and a default value of "no" will be
set for --disable-foo / --without-foo.

However, apart from that, you've also dropped the leaving "--" from
various --enable-foo options and converted dashes to underscores, all
of which looks wrong. How were the changes tested?


On 8/23/21 3:12 AM, Andrej Valek wrote:
- Some distributions with UTF-8 locale have problem when National Language
Support is enabled. Add there an option to disable it.
- refresh options based on

Signed-off-by: Andrej Valek <andrej.valek@...>
meta/recipes-support/vim/ | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-support/vim/
index 17d1c24a7c..7cc47884f2 100644
--- a/meta/recipes-support/vim/
+++ b/meta/recipes-support/vim/
@@ -54,19 +54,21 @@ do_compile() {

-#Available PACKAGECONFIG options are gtkgui, acl, x11, tiny
+#Available PACKAGECONFIG options are gtkgui, acl, x11, tiny, selinux,
+elfutils, nls
${@bb.utils.filter('DISTRO_FEATURES', 'acl selinux', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 gtkgui', '',
d)} \
+ nls \

PACKAGECONFIG[gtkgui] = "--enable-gui=gtk3,--enable-gui=no,gtk+3"
-PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
+PACKAGECONFIG[acl] = "enable_acl="yes",--disable-acl,acl,"
is 'yes' needed to be explicit ? I thought --enable-XYZ meant it implicitly

PACKAGECONFIG[x11] = "--with-x,--without-x,xt,"
PACKAGECONFIG[tiny] = "--with-features=tiny,--with-features=big,,"
-PACKAGECONFIG[selinux] = "--enable-selinux,--disable-selinux,libselinux,"
+PACKAGECONFIG[selinux] = "enable_selinux="yes",--disable-selinux,libselinux,"
PACKAGECONFIG[elfutils] = "--enable-elf-check,,elfutils,"
+PACKAGECONFIG[nls] = "enable_nls="yes",--disable-nls,,"

--disable-gpm \

Join to automatically receive all group messages.