Re: [PATCH] util-linux.inc: add fallocate only for class-target


Burton, Ross <ross.burton@...>
 

On 27 July 2018 at 00:58, Andre McCurdy <armccurdy@...> wrote:
On Thu, Jul 26, 2018 at 4:34 PM, Burton, Ross <ross.burton@...> wrote:
On 26 July 2018 at 14:58, Ioan-Adrian Ratiu <adrian.ratiu@...> wrote:
Because the util-linux_2.32.bb recipe explicitely disables fallocate
for nativesdk triggering build warnings:
Does anyone know why util-linux disables fallocate for nativesdk and
native builds?
Seems to date back to this commit:

http://git.openembedded.org/openembedded-core/commit/?id=17f3c548caf4adec37c3bbb139aa6b3900419794

+# fallocate is glibc 2.10, fallocate64 is glibc 2.11
+# we need to disable it for older versions
+EXTRA_OECONF += "ac_cv_func_fallocate=no"
+EXTRA_OECONF_virtclass-native += "--disable-fallocate
--disable-use-tty-group"
Well done, it was late and I got bored following the git-blame log. :)

Sounds like historical reasons to me, does anyone object to dropping this?
Ross

Join openembedded-core@lists.openembedded.org to automatically receive all group messages.