On 7/7/20 6:33 PM, hongxu wrote:
On 7/7/20 7:42 PM, Richard Purdie wrote:
A number of upstream git repos we build from are transitioning "master"Yes, we've met the same issue twice,
branches to "main" branches. They're doing this and removing the old
iso-codes: switch upstream branch master -> main
libmodulemd: switch branch master -> main
Ideally, we could support both of master and main as default branch,
if any of them exist, it should work, but the affect of the fix
is overall, we need to consider git, gitsm, lfs.
The scale of the problem this causes us is only just becoming apparent.
iso-codes did this, I tested a patch to update master-next. Everything
was fine until I did this as DL_DIR has "master" in it.
After I tested the change in master-next, the new main branch was added
to DL_DIR and the old master branch was removed. This broke master
which now no longer had the correct source in the mirror or from
upstream. It will have also broken dunfell and perhaps a number of
other releases. Those do have sources from the release period we could
use but they're not configured to fall back to them at present (they
probably should be?).
I suspect this is going to be a growing trend so we're going to have to
adapt our mirroring to cope better with this, perhaps by not removing
any branches/heads, only every updating/changing.
I wanted to give people a heads up that this is going to be an
I think we should change to not assume default and ask branch= to be explicit perhaps will avoid future issues of such implicit changes.