[oe] [PATCH, RFC] Cleanup / update QEMU related checks

Chris Larson clarson at kergoth.com
Mon Mar 1 23:57:33 UTC 2010

On Mon, Mar 1, 2010 at 3:22 PM, Denys Dmytriyenko <denis at denix.org> wrote:

> On Mon, Mar 01, 2010 at 02:18:28PM -0700, Tom Rini wrote:
> > First, we should be performing qemu-native related checks not on ARM,
> > but on ENABLE_BINARY_LOCALE_GENERATION (for both the ARM but no
> > generation and not ARM but generation) cases.  This clarifies what we do
> > in the first sub-check (aside: When can qemu-0.9.x die?).  This changes
> > the assume provided check to make sure that at least 'qemu' exists
> > (afaict this will exist for distribution packages as well as from-source
> > ones where we might not have qemu-arm, if the developer isn't doing arm)
> > using the standard check.  Finally (how I wrote it, not how it's in the
> > patch), correct (grammar and content) the comment about what GCC
> > versions are allowed.  My fault initially for not noticing the gcc
> > 3.3.x / 3.2.x stuff in the list.
> Heh, I have a local similar change to avoid unnecessary QEMU sanity check,
> when not doing binary locale generation. I wanted to push it later, but
> your
> fix looks better :)
> > Signed-off-by: Tom Rini <tom_rini at mentor.com>
> Acked-by: Denys Dmytriyenko <denis at denix.org>

Looks sane to me.

Acked-by: Chris Larson <chris_larson at mentor.com>
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

More information about the Openembedded-devel mailing list