<div dir="ltr">On 1 November 2017 at 22:04, Richard Purdie <span dir="ltr"><<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, 2017-10-31 at 21:25 -0200, Otavio Salvador wrote:<br>
> On Tue, Oct 31, 2017 at 9:16 PM, Burton, Ross <<a href="mailto:ross.burton@intel.com">ross.burton@intel.com</a>><br>
> wrote:<br>
> ><br>
> > On 21 October 2017 at 13:06, Richard Purdie<br>
> > <<a href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@<wbr>linuxfoundation.org</a>> wrote:<br>
> > >Â <br>
</span>> > > diff --git a/scripts/oe-buildenv-internal b/scripts/oe-buildenv-<br>
<span class="">> > > internal<br>
> > > index e6cd141..abc5aff 100755<br>
> > > --- a/scripts/oe-buildenv-internal<br>
> > > +++ b/scripts/oe-buildenv-internal<br>
> > > @@ -105,6 +105,11 @@ fi<br>
> > ><br>
> > > Â BITBAKEDIR=$(readlink -f "$BITBAKEDIR")<br>
> > > Â BUILDDIR=$(readlink -f "$BUILDDIR")<br>
> > > +if [ -z "$BBPATH" ]; then<br>
> > > +Â Â Â Â BBPATH=$BUILDDIR<br>
> > > +fi<br>
> > > +<br>
> > > +export BBPATH<br>
> ><br>
> > This breaks the use-case of the user switching between build<br>
> > directories as<br>
> > re-executing oe-init-build-env doesn't change BBPATH.<br>
> I know and that's why I asked for a warning! ;-)<br>
<br>
</span>My patch as it stands clearly can't go in.<br>
<br>
Our options are:<br>
<br>
a) make that codepath unconditional (which may be no bad thing) and <br>
  use BBPATH<br>
b) use a specific variable for bitbake, the script sets BUILDDIR<br>
c) start allowing the external code to set TOPDIR directly<br>
<br>
I think I'm leaning towards a) or possibly c). I don't really like b).<br>
I tried c) locally and its behaving oddly. a) is known to work.<br></blockquote><div><br></div><div>(a) seems like the right fix here. At least, that's what I expected to happen...</div><div><br></div><div>Ross </div></div></div></div>