<div dir="ltr">On Thu, Apr 28, 2016 at 7:34 AM, Peter Kjellerstedt <span dir="ltr"><<a href="mailto:peter.kjellerstedt@axis.com" target="_blank">peter.kjellerstedt@axis.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634">Yes, it was intentional. I mentioned this in the cover letter. I can of course add something about it to the commit message as well if you like.</span></p></div></div></blockquote><div><br></div><div>That's what a commit message is for, yes, to describe why something is being changed. The cover letter isn't going to end up in the git history. If it hasn't yet been merged, I think it'd be nice to get it improved, so someone looking at the logs later understands the intention. Thanks.</div><div>Â </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><div style="border-style:none none none solid;border-left-color:blue;border-left-width:1.5pt;padding:0cm 0cm 0cm 4pt"><div><div class="h5"><div><div><div><blockquote style="border-style:none none none solid;border-left-color:rgb(204,204,204);border-left-width:1pt;padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm"><p class="MsoNormal">
<br>
-Â Â scms = [base_get_metadata_git_revision, \<br>
-Â Â Â Â Â Â base_get_metadata_svn_revision]<br>
+Â Â scms = [base_get_metadata_git_revision]<u></u><u></u></p>
</blockquote>
<div>
<p class="MsoNormal"><u></u>Â <u></u></p>
</div>
<div>
<p class="MsoNormal">Was this change intended? Because it doesn't match up with the commit message, as far as I can see.</p></div></div></div></div></div></div></div></div></div></blockquote></div>-- <br><div class="gmail_signature">Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>