<div dir="ltr"><div class="gmail_extra">On 29 January 2016 at 12:22, Ioan-Adrian Ratiu <span dir="ltr"><<a href="mailto:adrian.ratiu@ni.com" target="_blank">adrian.ratiu@ni.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":28s" class="a3s" style="overflow:hidden">+PACKAGECONFIG_append = " ldap crypto sqlite3"<br></div></blockquote><div><br></div><div>Never use PACKAGECONFIG_append in a recipe as then they can't easily be disabled. Recipes should use PACAKGECONFIG??="options".</div><div><br></div><div>apr is used by more than just apache, and the need for LDAP and sqlite isn't universal. I think these should default to disabled and the the user/distro/whatever can enable them if required.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":28s" class="a3s" style="overflow:hidden">
+PACKAGECONFIG[ldap] = "--with-ldap,,openldap,"<br></div></blockquote><div><br></div><div>You need a --without-ldap here.</div><div>Â </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":28s" class="a3s" style="overflow:hidden">
+PACKAGECONFIG[crypto] = "--with-crypto,,,"<br></div></blockquote><div><br></div><div>Dito.</div><div>Â </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":28s" class="a3s" style="overflow:hidden">
+PACKAGECONFIG[sqlite3] = "--with-sqlite3=${STAGING_DIR_HOST}${prefix},,,"<br></div></blockquote><div><br></div><div>Ditto.</div><div><br></div><div>Also, there's no point adding extra trailing commas, they just look ugly.</div><div>Â </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":28s" class="a3s" style="overflow:hidden">+FILES_${PN}Â Â Â += "${libdir}/apr-util-1/apr_ldap-1.so"<br>
+FILES_${PN}-dev += "${libdir}/apr-util-1/apr_ldap.so* ${libdir}/apr-util-1/<a href="http://apr_ldap.la" rel="noreferrer" target="_blank">apr_ldap.la</a>"<br>
+FILES_${PN}-staticdev += "${libdir}/apr-util-1/apr_ldap.a"<br>
+<br>
+FILES_${PN}Â Â Â += "${libdir}/apr-util-1/apr_crypto_openssl-1.so"<br>
+FILES_${PN}-dev += "${libdir}/apr-util-1/apr_crypto_openssl.so* ${libdir}/apr-util-1/<a href="http://apr_crypto_openssl.la" rel="noreferrer" target="_blank">apr_crypto_openssl.la</a>"<br>
+FILES_${PN}-staticdev += "${libdir}/apr-util-1/apr_crypto_openssl.a"<br>
+<br>
+FILES_${PN}Â Â Â += "${libdir}/apr-util-1/apr_dbd_sqlite3-1.so"<br>
+FILES_${PN}-dev += "${libdir}/apr-util-1/apr_dbd_sqlite3.so* ${libdir}/apr-util-1/<a href="http://apr_dbd_sqlite3.la" rel="noreferrer" target="_blank">apr_dbd_sqlite3.la</a>"<br>
+FILES_${PN}-staticdev += "${libdir}/apr-util-1/apr_dbd_sqlite3.a"<br>
+<br>
 FILES_${PN}   += "${libdir}/apr-util-1/apr_dbm_gdbm-1.so"<br>
 FILES_${PN}-dev += "${libdir}/aprutil.exp ${libdir}/apr-util-1/apr_dbm_gdbm.so* ${libdir}/apr-util-1/<a href="http://apr_dbm_gdbm.la" rel="noreferrer" target="_blank">apr_dbm_gdbm.la</a>"<br>
 FILES_${PN}-staticdev += "${libdir}/apr-util-1/apr_dbm_gdbm.a"</div></blockquote></div><br></div><div class="gmail_extra">Please change the existing FILES_ to use globs instead of listing all the files to match explicitly.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Ross</div></div>