[OE-core] [PATCH 1/1] sanity.bbclass: check for validity of TMPDIR
richard.purdie at linuxfoundation.org
Thu Nov 14 13:12:12 UTC 2013
On Thu, 2013-11-14 at 21:07 +0800, Qi.Chen at windriver.com wrote:
> From: Chen Qi <Qi.Chen at windriver.com>
> TMPDIR must be an absolute path, otherwise, the build will fail.
> Special characters in TMPDIR will also cause build failures.
> This patch enables checking for the validity of TMPDIR.
> Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
> meta/classes/sanity.bbclass | 7 +++++++
> 1 file changed, 7 insertions(+)
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 83378b0..e45906e 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -672,6 +672,13 @@ def check_sanity_everybuild(status, d):
> with open(checkfile, "w") as f:
> + # Check if TMPDIR contains invalid characters, and check if it is an absolute path
> + valid_tmpdir_regexp = "^/[a-zA-Z0-9\-_/.~]+$"
> + import re
> + valid_pattern = re.compile(valid_tmpdir_regexp)
> + if not valid_pattern.match(tmpdir):
> + status.addresult("Error, you have special characters in TMPDIR directory path or your TMPDIR is not an absolute path. The TMPDIR should match the this regexp: ^/[a-zA-Z0-9\-_/.~]$")
I'm ok with the check itself however this does not need to be run every
build. It needs to run when tmpdir changes only.
More information about the Openembedded-core