[oe-commits] [openembedded-core] 01/20: package.bbclass: fix directories setuid and setgid bits

git at git.openembedded.org git at git.openembedded.org
Thu Jun 27 23:06:46 UTC 2019

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit 0f82b53a650e76e0129fae6ce7581a41d042315b
Author: Joël Esponde <joel.esponde at easymile.com>
AuthorDate: Thu Jun 27 11:12:04 2019 +0200

    package.bbclass: fix directories setuid and setgid bits
    populate_packages relies on ``mkdir`` to both create a directory and set
    its permissions. However, ``mkdir`` honors the ``umask`` value.
    Therefore, some bits may be lost in the operation. In our case, the
    setgid bit on the directories were lost.
    This commit fixes this by having a distinct call to create the directory
    and to set the permissions.
    Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot at easymile.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
 meta/classes/package.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 20d72bb..cd223a1 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -1216,7 +1216,8 @@ python populate_packages () {
                 src = os.path.join(src, p)
                 dest = os.path.join(dest, p)
                 fstat = cpath.stat(src)
-                os.mkdir(dest, fstat.st_mode)
+                os.mkdir(dest)
+                os.chmod(dest, fstat.st_mode)
                 os.chown(dest, fstat.st_uid, fstat.st_gid)
                 if p not in seen:

To stop receiving notification emails like this one, please contact
the administrator of this repository.

More information about the Openembedded-commits mailing list