[bitbake-devel] [PATCH] bitbake-worker: don't reassign sys.stdout
ed.bartosh at linux.intel.com
Mon Jul 4 21:53:59 UTC 2016
Worker needs input stream in binary mode as it reads binary content
from it. Current code does it by detaching a buffer from sys.stdin
and assigning it back to sys.stdin.
Detached buffer is io.BufferedReader in binary mode. This operation
is implicit as its purpose is not easily understandable from the code.
Replacing it with fdopen(sys.stdin.fileno(), 'rb') should make the
code more understandable.
Assigning the buffer to sys.stdin is not needed as worker doesn't
use sys.stdin. Moreover, it leads to difficult to debug issues down
the stack. For example, devpyshell doesn't work without reopening
sys.stdin in text mode. This is not needed anymore after this fix as
sys.stdin is not changed in worker code and remains in text mode.
Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
bitbake/bin/bitbake-worker | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/bitbake/bin/bitbake-worker b/bitbake/bin/bitbake-worker
index 5d062a2..963b4cd 100755
@@ -436,8 +436,7 @@ class BitbakeWorker(object):
- sys.stdin = sys.stdin.detach()
- worker = BitbakeWorker(sys.stdin)
+ worker = BitbakeWorker(os.fdopen(sys.stdin.fileno(), 'rb'))
if not profiling:
More information about the bitbake-devel